Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register with consul client #10

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

rfyiamcool
Copy link

summary

  1. add NewConsulRegisterWithClient function. because app already consul client at startup, don't create client again.
  2. foamt readme.md
  3. I think it is necessary to mark in the document what to do if health check is not used. because some network architectures are complicate, consul cannot connect to the registered node. 😁 It will be more friendly to explain in the documentation.

@GuangmingLuo
Copy link
Member

@rfyiamcool Hello,rebase 下 master 代码

README.md Outdated Show resolved Hide resolved
@rfyiamcool rfyiamcool force-pushed the feat/register_with_client branch 2 times, most recently from 8b15aa9 to 743128b Compare November 27, 2024 07:07
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rfyiamcool
To complete the pull request process, please ask for approval from baiyutang after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rfyiamcool rfyiamcool force-pushed the feat/register_with_client branch from 743128b to d66e480 Compare November 27, 2024 07:25
@baiyutang baiyutang merged commit 232fbcb into kitex-contrib:main Dec 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants